Skip to content

fix: add validity no_nulls and fix usage#7487

Merged
joseph-isaacs merged 3 commits intodevelopfrom
ji/fix-validity-no-nulls
Apr 16, 2026
Merged

fix: add validity no_nulls and fix usage#7487
joseph-isaacs merged 3 commits intodevelopfrom
ji/fix-validity-no-nulls

Conversation

@joseph-isaacs
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs marked this pull request as ready for review April 16, 2026 16:03
@joseph-isaacs joseph-isaacs enabled auto-merge (squash) April 16, 2026 16:03
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 16, 2026

Merging this PR will improve performance by 19.67%

⚡ 9 improved benchmarks
✅ 1154 untouched benchmarks
⏩ 1457 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation take_map[(0.1, 0.5)] 1,154.5 µs 990.5 µs +16.55%
Simulation take_map[(0.1, 1.0)] 2 ms 1.7 ms +19.06%
Simulation patched_take_10k_contiguous_patches 258.1 µs 228.2 µs +13.09%
Simulation patched_take_10k_dispersed 316 µs 286.2 µs +10.42%
Simulation patched_take_10k_contiguous_not_patches 258.4 µs 228.6 µs +13.06%
Simulation patched_take_10k_random 270.3 µs 240.4 µs +12.44%
Simulation patched_take_10k_first_chunk_only 302 µs 272.2 µs +10.97%
Simulation take_10k_first_chunk_only 270.6 µs 226.1 µs +19.67%
Simulation take_10k_dispersed 284.4 µs 239.9 µs +18.56%

Comparing ji/fix-validity-no-nulls (9edc0e6) with develop (91b4c75)

Open in CodSpeed

Footnotes

  1. 1457 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@joseph-isaacs joseph-isaacs added the changelog/fix A bug fix label Apr 16, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs merged commit 67c1655 into develop Apr 16, 2026
58 checks passed
@joseph-isaacs joseph-isaacs deleted the ji/fix-validity-no-nulls branch April 16, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants